search

acquia / orca

A tool for testing a company's software packages together in the context of a realistic, functioning, best practices Drupal build
GNU General Public License v2.0
25 stars 21 forks source link

Fix static analysis tests #558

Closed secretsayan closed 5 months ago

TravisCarden commented 5 months ago

You definitely don't need my review on something this simple, @secretsayan. In a case like this, if the tests pass, go ahead. 🙂

secretsayan commented 5 months ago

You definitely don't need my review on something this simple, @secretsayan. In a case like this, if the tests pass, go ahead. 🙂

I wanted to show you, how phpunit 10 is breaking our simplest tests :(

TravisCarden commented 5 months ago

Okay. Then is there something you need from me?

secretsayan commented 5 months ago

Okay. Then is there something you need from me?

If you don't have any comments/suggestions, I will just merge it.

TravisCarden commented 5 months ago

No, no concerns. In fact, it seems better this way. I assume static analysis complained because of duplicate keys, which are a genuine issue to be fixed. Also, the arrays now reflect the names of the test method arguments. So it seems better all around.

secretsayan commented 5 months ago

No, no concerns. In fact, it seems better this way. I assume static analysis complained because of duplicate keys, which are a genuine issue to be fixed. Also, the arrays now reflect the names of the test method arguments. So it seems better all around.

Okay, then merging