[Feature Request] Allow warnings to pass phpcs

acquia / orca

A tool for testing a company's software packages together in the context of a realistic, functioning, best practices Drupal build

GNU General Public License v2.0

25 stars 21 forks source link

Open kaynenh opened 4 years ago

kaynenh commented 4 years ago

The Content Hub module is currently failing phpcs with the following error (4 times):

 1 | WARNING | File appears to be minified and cannot be
   |         | processed (Internal.Tokenizer.Exception)

These warnings are generated from 2 minified css and 2 minified js files, so they are definitely not something we want phpcs even sniffing.

Could we change the severity of warnings so that they do not fail phpcs? Thanks for considering!

kaynenh commented 4 years ago

Removing minified css/js from code sniffing would also be enough to fix this, so this issue may be enough: https://github.com/acquia/orca/issues/63