search

acquia / waterwheel.js

A generic JavaScript helper library to query and manipulate Drupal 8 via core REST and JSON API
https://github.com/acquia/waterwheel.js
233 stars 26 forks source link

format parameter being used inconsistently #25

Closed infiniteluke closed 7 years ago

infiniteluke commented 7 years ago

It appears the format parameter (as in part of the function signature) is being used differently across methods. In some cases it's being sent as a url param and in some cases it's being sent as a Content-type header. I don't understand Drupal's API enough to suggest a solution, but it's confused me a couple times.

Could the application/ be abstracted on post() and patch() to allow for consistent values being passed or will that require too much massaging for other formats?

This issue is tangential to acquia/waterwheel/pull/24

infiniteluke commented 7 years ago

Chatted with @mattgrill about this. As the D8 REST API improves, these kinds of inconsistencies will also improve on the waterwheel side. This is a minor inconvenience and not a bug. Safe to close.