search

acquire-project / acquire-common

Core libraries, runtime, and common devices driver for Acquire
Apache License 2.0
0 stars 7 forks source link

logs write full source paths #26

Open nclack opened 1 year ago

nclack commented 1 year ago

Log messages look like this right now:

DEBUG    acquire.runtime:runtime.rs:42 C:\acquire-python\acquire-driver-zarr\src\acquire-core-libs\src\acquire-device-hal\device\hal\device.manager.cpp:223 - `anonymous-namespace'::DeviceManagerV0::select(): Selecting (3,0) for Camera "VIEWORKS VP-151MX-M6H0 MP151BBX050"
DEBUG    acquire.runtime:runtime.rs:42 C:\acquire-python\acquire-driver-zarr\src\acquire-core-libs\src\acquire-device-hal\device\hal\device.manager.cpp:223 - `anonymous-namespace'::DeviceManagerV0::select(): Selecting (0,5) for Storage "Trash"
DEBUG    acquire.runtime:runtime.rs:42 C:\acquire-python\acquire-driver-zarr\src\acquire-core-libs\src\acquire-device-hal\device\hal\device.manager.cpp:223 - `anonymous-namespace'::DeviceManagerV0::select(): Selecting (0,5) for Storage "Trash"
DEBUG    acquire.runtime:runtime.rs:42 C:\acquire-python\acquire-driver-zarr\src\acquire-core-libs\src\acquire-device-hal\device\hal\device.manager.cpp:223 - `anonymous-namespace'::DeviceManagerV0::select(): Selecting (0,5) for Storage "Trash"
DEBUG    acquire.runtime:runtime.rs:42 C:\acquire-python\acquire-driver-zarr\src\acquire-core-libs\src\acquire-device-hal\device\hal\device.manager.cpp:223 - `anonymous-namespace'::DeviceManagerV0::select(): Selecting (0,5) for Storage "Trash"
DEBUG    acquire.runtime:runtime.rs:42 C:\acquire-python\acquire-driver-zarr\src\acquire-core-libs\src\acquire-device-hal\device\hal\device.manager.cpp:223 - `anonymous-namespace'::DeviceManagerV0::select(): Selecting (0,5) for Storage "Trash"

It would be nice if there were some facility for increasing the signal-to-noise in the source-path part of the log line. Also, we probably don't want to expose full paths of build machines in shipped packages.

For example:

DEBUG    acquire.runtime:runtime.rs:42 acquire-device-hal\device\hal\device.manager.cpp:223 - `anonymous-namespace'::DeviceManagerV0::select(): Selecting (0,5) for Storage "Trash"

is shorter and communicates mostly the same info.