Move `reserve_image_shape` from `acquire_start` to `acquire_configure`

acquire-project / acquire-common

Core libraries, runtime, and common devices driver for Acquire

Apache License 2.0

0 stars 8 forks source link

Move `reserve_image_shape` from `acquire_start` to `acquire_configure` #33

Closed aliddell closed 6 months ago

aliddell commented 6 months ago

Having reserve_image_shape in acquire_start was an annoying workaround from when the Storage object was created during start and destroyed on stop. But now that storage is created at the latest during configure, we can reserve image shape earlier in the process.

nclack commented 6 months ago

Is reverse_image_shape still a necessary part of the Storage device api (kit/storage.h)?

aliddell commented 6 months ago

Is reverse_image_shape still a necessary part of the Storage device api (kit/storage.h)?

It is if you don't want the image shape to be part of the storage configuration, or for there to be a lag on the first append. The Zarr driver at least needs to know what the image shape is in order to allocate chunk buffers.