search

acran / teams-in-docker

run MS Teams for Linux in a docker container with x11docker
29 stars 6 forks source link

added versioning to the Docker image #6

Closed bryanpedini closed 2 years ago

bryanpedini commented 2 years ago

as the title says

acran commented 2 years ago

adding the version tag to the image makes it much harder to actually start a container from the correct image: currently simply the latest tag is started, see:

https://github.com/acran/teams-in-docker/blob/bfacf6dbbb46dda55e9350d85362753ddc7ae5b1/teams.sh#L7

With versioned tags the script would had to first list all available images and decide which one is the most recent...

bryanpedini commented 2 years ago

With versioned tags the script would had to first list all available images and decide which one is the most recent...

well, yes

adding the version tag to the image makes it much harder to actually start a container from the correct image

but also no... since Teams uses numbered (and not named) versions, and since Docker already sorts images automatically:

docker image ls --format {{.Repository}}:{{.Tag}} | grep "teams:" | tail -n1