search

acreloaded / acr

AssaultCube Reloaded (first-person-shooter game)
https://acr.victorz.ca
128 stars 23 forks source link

fixed ugly font bug when resetting OpenGL #210

Closed veksha closed 3 years ago

veksha commented 6 years ago

hello, guys. please, review this fix and consider to include in your repo. thanks. basically, it happens when you change video settings. white squares on loading screen appear instead of text.

theonlypwner commented 6 years ago

I would probably fix this issue differently.

Since the fonts aren't loaded yet, "resetting OpenGL" is never visible after calls to loadingscreen in resetgl. I would remove the text in those calls and add extra loadingscreen calls to show loading messages for fonts, textures, and models.

theonlypwner commented 3 years ago

Most of the time is spent loading textures, so I found that having a blank loading screen and adding text (1/3) after loading fonts and (2/3) after textures makes the most sense (see fc14cc9edb355602c20f596c83924d3bb275ba7b).

veksha commented 3 years ago

3/3. bug closed. :)

theonlypwner commented 3 years ago

It turns out that it is possible to start with resetting OpenGL (0/3), instead of just a blank loading screen (see 2cbfcdf2ad2aa7f1c6a7fb0db439105318937293).