search

acreloaded / acr

AssaultCube Reloaded (first-person-shooter game)
https://acr.victorz.ca
127 stars 23 forks source link

Add AppStream metadata #265

Closed Mailaender closed 3 months ago

Mailaender commented 4 months ago

required for https://github.com/acreloaded/acr/issues/264

theonlypwner commented 3 months ago

I'm not that familiar with Flatpak, so I have these questions:

Something similar seems to have been set up for AC (flathub/flathub#3221 and flathub/net.cubers.assault.AssaultCube), without requiring files to be added to the main repo at assaultcube/AC. Is there something different about how it needs to be set up for ACR? Is the idea to allow ACR to update the metadata directly in the main repo instead of having to update another repo?

When compared to other Flatpak apps, does this metadata belong in the main repo or in the other repo flathub/ca.victorz.acr.AssaultCubeReloaded?

The /packages folders from AC are distributed under the same license as AC, which requires them to be distributed in their entirety without modifications. Should <project_license> in ca.victorz.acr.AssaultCubeReloaded.appdata.xml be updated to be the same as the value in net.cubers.assault.AssaultCube.appdata.xml to reflect this?

Mailaender commented 3 months ago

These metadata and program launcher files should be maintained upstream. It is just https://github.com/assaultcube/AC/pull/453 is ignored because the project is not well maintained.

Yes, the project license should also include the asset licenses. I didn't find a good summary about which license is actually used, so I left that blank.

Mailaender commented 3 months ago

The folder can be changed, but a dot folder would make it invisible on Linux. This is not tied to Flatpak or Flathub. It is a universal Unix standard under the @freedesktop umbrella.