acrisci / simple-breakpad-server

Simple breakpad crash reports collecting server
https://www.npmjs.com/package/simple-breakpad-server
MIT License
67 stars 29 forks source link

Add originating request IP #4

Closed Jimbly closed 7 years ago

Jimbly commented 7 years ago

I need this, and this is probably generally useful. It would also be pretty reasonable to say all uploaded dumps should always store the originating IP, regardless of whether the user adds a parameter for this to their config.

acrisci commented 7 years ago

I agree. I think I would rather have this as a default property since it's pretty useful across the board.

Jimbly commented 7 years ago

Cool, I'll refactor things to do that by default.

Jimbly commented 7 years ago

Updated, simpler now =)

acrisci commented 7 years ago

:+1:

Now we have to figure out how to do migrations of the database to add this when we release to avoid bumping the major version every time we make a schema update to the database.