search

acristescu / OnlineGo

Repo for the OnlineGo Android app.
https://play.google.com/store/apps/details?id=io.zenandroid.onlinego
GNU General Public License v3.0
207 stars 52 forks source link

Board theme has no effect while Play Against AI #157

Open gzyguo opened 1 year ago

MathieuDreano commented 1 year ago

Same for joseki explorer. It was not using the same component as thé PvP boards if I remember

acristescu commented 1 year ago

Those two are relics of the old way of writing android apps, which is using view. This app was an early adopters of Compose, back when it was still in Alpha. Even so, the project started back in 2014-15 so not everything is migrated over to Compose.

I'm in the (very slow) process of migrating all the Fragments over to Composables, but it will take some time. I have migrated Settings (not released yet but it's on develop) and I'm in the process on migrating Stats (it's on my laptop).

At some point I'll replace those screens with Compose equivalents. In particular for the AI screen, I'm thinking of just adding AI functionality to the new face-to-face screen and just abandon the old AI screen. The reason is I tried some MVI architecture with it and it seems to create a lot of problems (roughly 80% of issues reported into Firebase are from that screen alone).

This will take a few month though, I'm going to leave this ticket open just in case somebody is impatient and wants to tinker with the old BoardView to make it honor the theme. It shouldn't be hard as the old board view still loads the darker board for dark mode.

gzyguo commented 1 year ago

Those two are relics of the old way of writing android apps, which is using view. This app was an early adopters of Compose, back when it was still in Alpha. Even so, the project started back in 2014-15 so not everything is migrated over to Compose.

I'm in the (very slow) process of migrating all the Fragments over to Composables, but it will take some time. I have migrated Settings (not released yet but it's on develop) and I'm in the process on migrating Stats (it's on my laptop).

At some point I'll replace those screens with Compose equivalents. In particular for the AI screen, I'm thinking of just adding AI functionality to the new face-to-face screen and just abandon the old AI screen. The reason is I tried some MVI architecture with it and it seems to create a lot of problems (roughly 80% of issues reported into Firebase are from that screen alone).

This will take a few month though, I'm going to leave this ticket open just in case somebody is impatient and wants to tinker with the old BoardView to make it honor the theme. It shouldn't be hard as the old board view still loads the darker board for dark mode.

The AI and free board integration is cool and it's desired from now.