some fixes, pull in the new fireconfig

drmorr0 commented 5 months ago

[x] I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

Description

Update to new fireconfig, fix the labelselector for sk-cloudprov

Testing done

make test
manual testing

drmorr0 commented 5 months ago

Kubernetes Object DAG

%%{init: {'themeVariables': {'mainBkg': '#ddd'}}}%%
graph LR

classDef default color:#000
subgraph global
  direction LR
  global/simkube[<b>Namespace</b><br>simkube]
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

subgraph sk-cloudprov
  direction LR
  kube-system/sk-cloudprov-svc[<b>Service</b><br>sk-cloudprov-svc]
  kube-system/sk-cloudprov-depl[<b>Deployment</b><br>sk-cloudprov-depl]
  kube-system/sk-cloudprov-sa[<b>ServiceAccount</b><br>sk-cloudprov-sa]
  sk-cloudprov/sk-cloudprov-crb[<b>ClusterRoleBinding</b><br>sk-cloudprov-crb]
  kube-system/sk-cloudprov-cluster-autoscaler-depl[<b>Deployment</b><br>sk-cloudprov-cluster-autoscaler-depl]
  kube-system/sk-cloudprov-cluster-autoscaler-sa[<b>ServiceAccount</b><br>sk-cloudprov-cluster-autoscaler-sa]
  sk-cloudprov/sk-cloudprov-cluster-autoscaler-crb[<b>ClusterRoleBinding</b><br>sk-cloudprov-cluster-autoscaler-crb]
  kube-system/sk-cloudprov-cluster-autoscaler-config[<b>ConfigMap</b><br>sk-cloudprov-cluster-autoscaler-config]
  kube-system/sk-cloudprov-sa--->kube-system/sk-cloudprov-depl
  sk-cloudprov/sk-cloudprov-crb--->kube-system/sk-cloudprov-depl
  kube-system/sk-cloudprov-cluster-autoscaler-sa--->kube-system/sk-cloudprov-cluster-autoscaler-depl
  sk-cloudprov/sk-cloudprov-cluster-autoscaler-crb--->kube-system/sk-cloudprov-cluster-autoscaler-depl
  kube-system/sk-cloudprov-cluster-autoscaler-config--->kube-system/sk-cloudprov-cluster-autoscaler-depl
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

subgraph sk-vnode
  direction LR
  simkube/sk-vnode-depl[<b>Deployment</b><br>sk-vnode-depl]
  simkube/sk-vnode-sa[<b>ServiceAccount</b><br>sk-vnode-sa]
  sk-vnode/sk-vnode-crb[<b>ClusterRoleBinding</b><br>sk-vnode-crb]
  simkube/sk-vnode-node-skeleton[<b>ConfigMap</b><br>sk-vnode-node-skeleton]
  simkube/sk-vnode-sa--->simkube/sk-vnode-depl
  sk-vnode/sk-vnode-crb--->simkube/sk-vnode-depl
  simkube/sk-vnode-node-skeleton--->simkube/sk-vnode-depl
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

subgraph sk-tracer
  direction LR
  simkube/sk-tracer-svc[<b>Service</b><br>sk-tracer-svc]
  simkube/sk-tracer-depl[<b>Deployment</b><br>sk-tracer-depl]
  simkube/sk-tracer-sa[<b>ServiceAccount</b><br>sk-tracer-sa]
  sk-tracer/sk-tracer-crb[<b>ClusterRoleBinding</b><br>sk-tracer-crb]
  simkube/sk-tracer-tracer-config[<b>ConfigMap</b><br>sk-tracer-tracer-config]
  simkube/sk-tracer-sa--->simkube/sk-tracer-depl
  sk-tracer/sk-tracer-crb--->simkube/sk-tracer-depl
  simkube/sk-tracer-tracer-config--->simkube/sk-tracer-depl
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

subgraph sk-ctrl
  direction LR
  simkube/sk-ctrl-depl[<b>Deployment</b><br>sk-ctrl-depl]
  simkube/sk-ctrl-sa[<b>ServiceAccount</b><br>sk-ctrl-sa]
  sk-ctrl/sk-ctrl-crb[<b>ClusterRoleBinding</b><br>sk-ctrl-crb]
  simkube/sk-ctrl-sa--->simkube/sk-ctrl-depl
  sk-ctrl/sk-ctrl-crb--->simkube/sk-ctrl-depl
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

subgraph test
  direction LR
  simkube/test-depl[<b>Deployment</b><br>test-depl]
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

global--->sk-cloudprov
global--->sk-vnode
global--->sk-tracer
global--->sk-ctrl
global--->test

%% STYLE DEFINITIONS START
  style simkube/sk-ctrl-depl fill:#cb4
  style kube-system/sk-cloudprov-depl fill:#cb4
  style kube-system/sk-cloudprov-cluster-autoscaler-depl fill:#6ce
  style simkube/sk-vnode-depl fill:#6ce
  style simkube/sk-tracer-depl fill:#6ce
  style simkube/test-depl fill:#6ce
%% STYLE DEFINITIONS END

New object Deleted object Updated object Updated object (causes pod recreation)

Detailed Diff

#### kube-system/sk-cloudprov-cluster-autoscaler-depl: Changed

``` root['metadata']['labels']: not present --> { "fireconfig.io/app": "cluster-autoscaler" } ```

#### kube-system/sk-cloudprov-depl: ChangedWithPodRecreate

``` root['spec']['template']['spec']['containers'][0]['args'][1]: not present --> "-A" ``` ``` root['spec']['template']['spec']['containers'][0]['args'][2]: not present --> "fireconfig.io/app=sk-vnode" ``` ``` root['metadata']['labels']: not present --> { "fireconfig.io/app": "sk-cloudprov" } ```

#### simkube/sk-ctrl-depl: ChangedWithPodRecreate

``` root['spec']['template']['spec']['nodeSelector']['type']: "kind-workerrrr" --> "kind-worker" ``` ``` root['metadata']['labels']: not present --> { "fireconfig.io/app": "sk-ctrl" } ```

#### simkube/sk-tracer-depl: Changed

``` root['metadata']['labels']: not present --> { "fireconfig.io/app": "sk-tracer" } ```

#### simkube/sk-vnode-depl: Changed

``` root['metadata']['labels']: not present --> { "fireconfig.io/app": "sk-vnode" } ```

#### simkube/test-depl: Changed

``` root['metadata']['labels']: not present --> { "fireconfig.io/app": "test" } ```

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e741c1b) 58.60% compared to head (0d072bb) 58.60%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #88 +/- ## ======================================= Coverage 58.60% 58.60% ======================================= Files 38 38 Lines 2215 2215 ======================================= Hits 1298 1298 Misses 893 893 Partials 24 24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

acrlabs / simkube