skctl run now specifies duration, plus some bug fixes

drmorr0 commented 4 months ago

[x] I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

Description

fix skctl snapshot hang (I think)
fix sk-tracer panics if the channel receivers go away
fix SimulationStatus updates if the Job completes successfully
update the Simulation spec to add a duration field
move the duration arg from skctl snapshot to skctl run, which makes more sense

Testing done

make test (with a few new tests)
manual testing

drmorr0 commented 4 months ago

Kubernetes Object DAG

%%{init: {'themeVariables': {'mainBkg': '#ddd'}}}%%
graph LR

classDef default color:#000
subgraph global
  direction LR
  global/simkube[<b>Namespace</b><br>simkube]
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

subgraph sk-tracer
  direction LR
  simkube/sk-tracer-svc[<b>Service</b><br>sk-tracer-svc]
  simkube/sk-tracer-depl[<b>Deployment</b><br>sk-tracer-depl]
  simkube/sk-tracer-sa[<b>ServiceAccount</b><br>sk-tracer-sa]
  sk-tracer/sk-tracer-crb[<b>ClusterRoleBinding</b><br>sk-tracer-crb]
  simkube/sk-tracer-tracer-config[<b>ConfigMap</b><br>sk-tracer-tracer-config]
  simkube/sk-tracer-sa--->simkube/sk-tracer-depl
  sk-tracer/sk-tracer-crb--->simkube/sk-tracer-depl
  simkube/sk-tracer-tracer-config--->simkube/sk-tracer-depl
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

subgraph sk-ctrl
  direction LR
  simkube/sk-ctrl-depl[<b>Deployment</b><br>sk-ctrl-depl]
  simkube/sk-ctrl-sa[<b>ServiceAccount</b><br>sk-ctrl-sa]
  sk-ctrl/sk-ctrl-crb[<b>ClusterRoleBinding</b><br>sk-ctrl-crb]
  simkube/sk-ctrl-sa--->simkube/sk-ctrl-depl
  sk-ctrl/sk-ctrl-crb--->simkube/sk-ctrl-depl
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

subgraph test
  direction LR
  simkube/test-depl[<b>Deployment</b><br>test-depl]
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

global--->sk-tracer
global--->sk-ctrl
global--->test

%% STYLE DEFINITIONS START
%% STYLE DEFINITIONS END

New object Deleted object Updated object Updated object (causes pod recreation)

Detailed Diff

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 65.30612% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 69.69%. Comparing base (74b99d6) to head (041ca7a).

Files	Patch %	Lines
cli/snapshot.rs	0.00%	7 Missing :warning:
src/watch/dyn_obj_watcher.rs	0.00%	3 Missing :warning:
cli/run.rs	0.00%	2 Missing :warning:
ctrl/controller.rs	86.66%	2 Missing :warning:
driver/main.rs	0.00%	1 Missing :warning:
src/time.rs	80.00%	1 Missing :warning:
src/watch/pod_watcher.rs	66.66%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #98 +/- ## ========================================== + Coverage 69.49% 69.69% +0.19% ========================================== Files 38 38 Lines 1898 1917 +19 ========================================== + Hits 1319 1336 +17 - Misses 579 581 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

acrlabs / simkube