search

acro5piano / react-native-big-calendar

gcal/outlook like calendar component for React Native
https://react-native-big-calendar.vercel.app
MIT License
441 stars 145 forks source link

Update useNow.ts #992

Closed AdamLee321 closed 9 months ago

AdamLee321 commented 10 months ago

Refactor useNow hook to accurately update as the time changes instead of every 60 seconds

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-big-calendar ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 1:49pm
acro5piano commented 10 months ago

@AdamLee321 Thank you for your pull request. However, as the current code does, it sounds okay to update the now indicator for every 60 seconds because we usually don't care exact time under a minute in calendar. If I miss something, can you describe your usecase a bit more? Thanks!

AdamLee321 commented 9 months ago

Hey, thanks for taking the time to review. Yeah I understand but in my case I need to show the current time and it was not updating accurately enough for my use case. Just thought I would make the PR just in case. Thanks for the great library!

acro5piano commented 9 months ago

Thanks. If the PR provides a customization option for the interval, it would be nice to merge.