search

across-protocol / contracts

Smart contracts for Across protocol
Other
98 stars 50 forks source link

Several SolHint issues raised by GH Actions #263

Open james-a-morris opened 1 year ago

james-a-morris commented 1 year ago

There are several unchecked issues that Solhint has raised.

Here is an example of a diff that contains these issues: https://github.com/across-protocol/contracts-v2/pull/262/files#

The following actions script has raised these issues: https://github.com/across-protocol/contracts-v2/actions/runs/4469185546/jobs/7850936946?pr=262

The files that these lint issues affect are:

  1. contracts/chain-adapters/Arbitrum_Adapter.sol
  2. contracts/chain-adapters/Arbitrum_SendTokensAdapter.sol
  3. contracts/chain-adapters/Succinct_Adapter.sol
  4. contracts/external/WETH9.sol
ogubuikeAlex commented 1 year ago

Hey @james-a-morris Can I work on this?

james-a-morris commented 1 year ago

Hey @james-a-morris

Can I work on this?

Hello and sorry for the late reply! You're always welcome to contribute to Across. 🙂

If you're still interested, feel free to put up a PR. I promise we have a much faster turn around on responding to pull requests 😅

ogubuikeAlex commented 1 year ago

Great

Narendra-Reddy1 commented 3 months ago

Hey @king-Alex-d-great , are still working on this particular issue?