search

acroy / Expokit.jl

Julia implementation of EXPOKIT routines
Other
26 stars 11 forks source link

refactoring #12

Closed mforets closed 6 years ago

acroy commented 6 years ago

Great! Could you homogenise the tabs in the the new file (which is probably my fault)?

mforets commented 6 years ago

done. for the style, i changed the TAB character by 4 spaces, so normally this affected all lines.. if didn't want this change let me know, and i'll revert :)

acroy commented 6 years ago

Thanks! Looks good. The conflict is probably resolved automatically if you rebase against the current master (because I merged @garrison's PR yesterday).

mforets commented 6 years ago

Got it, thanks. Let's see if it applies now.

acroy commented 6 years ago

Perfect.

mforets commented 6 years ago

Ooops! The fix b8e02a3 was overwritten. How didn't i see it?! Shall I cherry-pick that commit and push it on top of mforets:refactoring?

acroy commented 6 years ago

Don't worry. It was just one line and I just changed it manually.