search

acroy / Expokit.jl

Julia implementation of EXPOKIT routines
Other
26 stars 11 forks source link

Fix 0.7 depwarns in function signatures #26

Closed mforets closed 6 years ago

mforets commented 6 years ago

Fixes some (but not all) deprecation warnings in v.0.7.

mforets commented 6 years ago

ping?

acroy commented 6 years ago

Thanks! It seems that the way the package is initialized for Travis has to be changed under v0.7?

acroy commented 6 years ago

I think this still doesn't resolve the issue with the testing. For other packages I saw that they basically removed the script part altogether in travis.yml?

acroy commented 6 years ago

@mforets I changed the Travis script. Could you please rebase this PR against master? Then we can directly see which routines are still causing trouble ...

mforets commented 6 years ago

@acroy thanks for the update. now i get

julia> using Expokit
[ Info: Recompiling stale cache file /Users/mforets/.julia/compiled/v0.7/Expokit/vT6yJ.ji for Expokit [a1e7a1ef-7a5d-5822-a38c-be74e1bb89f4]
┌ Warning: Package Expokit does not have LinearAlgebra in its dependencies:
│ - If you have Expokit checked out for development and have
│   added LinearAlgebra as a dependency but haven't updated your primary
│   environment's manifest file, try `Pkg.resolve()`.
│ - Otherwise you may need to report an issue with Expokit
└ Loading LinearAlgebra into Expokit from project dependency, future warnings for Expokit are suppressed.
┌ Warning: Deprecated syntax `multiple line breaks between doc string and object` at /Users/mforets/.julia/dev/Expokit/src/phimv.jl:35.
│ Use `at most one line break` instead.
└ @ ~/.julia/dev/Expokit/src/phimv.jl:35

1) it complains that LinearAlgebra is missing from REQUIRE 2) some issue with line breaks in phimv line 35 3) testing the package still gives a ton of warnings, i've opened #33

acroy commented 6 years ago

Thanks! I am working on it ...