search

acrule / comet

Comet is a Jupyter Notebook extension that tracks changes to the notebook over time.
0 stars 0 forks source link

Restart-kernal-and-run-all action is not being tracked #3

Closed acrule closed 7 years ago

acrule commented 7 years ago

Check that other actions we are interested in are being tracked as well.

acrule commented 7 years ago

I think I have fixed the restart-kernal-and-run-all action tracking. However, when checking that we track all other action it seems the cut-copy-paste actions do not consistently executed by calling the relevant action in the ActionHandler. Sometimes, as when the cell is copied using the dropdown menu, the copy or paste function is called directly without calling the action.

Ways to fix this include:

  1. patching the cut-copy-paste functions to call a unique action that will be tracked
  2. rewriting the jupyter copy-paste code to always call the appropriate action
  3. leaving it as is and inconsistently tracking cut-copy-paste actions
acrule commented 7 years ago

Using method 1 above, I was able to consistently track cut, copy, and paste actions performed from the menu or buttons in the toolbar. However, I'm not able to track those performed using hotkeys (e.g., CMD-x,c,v). This seems consistent across Safari and Firefox.

acrule commented 7 years ago

see https://github.com/jupyter/notebook/blob/0ccb548238fb884dbbf0b96492f48e1d980103db/notebook/static/notebook/js/keyboardmanager.js#L126