Improvements to the OMIEData.FileReaders.marginal_price_file_reader, particularly the_process_line function. Added a new key "H25". Both the values for "H23" and "H25" are NaN when the file is for days with 23 and 25 days, respectively.
Refactor of test test_day_with_23_hours
New test test_day_with_25_hours
Motivation:
The motivation behind these changes is to handle the daylight saving time change, in a more accurate manner. The existing logic does not handle days with 25 hours. In days with 23 hours, the value for 23rd hour == 24th hour, which could be misleading.
Testing:
All unit tests in marginal_pricer_reader_test.py have passed successfully. The changes have verified to work correctly with the test files files.
Backwards Compatibility:
These changes are backward compatible with existing data files and should not break any existing functionality. However, it should be taken into consideration that the results retrieved by the client include 25 values, from now on.
Thank you for considering these improvements. I look forward to your feedback and am happy to make any necessary adjustments.
Description:
Motivation:
The motivation behind these changes is to handle the daylight saving time change, in a more accurate manner. The existing logic does not handle days with 25 hours. In days with 23 hours, the value for 23rd hour == 24th hour, which could be misleading.
Testing:
All unit tests in marginal_pricer_reader_test.py have passed successfully. The changes have verified to work correctly with the test files files.
Backwards Compatibility:
These changes are backward compatible with existing data files and should not break any existing functionality. However, it should be taken into consideration that the results retrieved by the client include 25 values, from now on.
Thank you for considering these improvements. I look forward to your feedback and am happy to make any necessary adjustments.