acryldata / datahub-actions

DataHub Actions is a framework for responding to changes to your DataHub Metadata Graph in real time.
42 stars 47 forks source link

fix: tweak datahub-kafka requirement #110

Closed hsheth2 closed 9 months ago

hsheth2 commented 9 months ago

This should enable pydantic 2 support. The acryl-datahub kafka source still requires pydantic v2, but the datahub-kafka sink does not. We only need the sink capabilities here.

Slack ref: https://datahubspace.slack.com/archives/CV2KB471C/p1706298872346799?thread_ts=1706201071.771369&cid=CV2KB471C

github-actions[bot] commented 9 months ago

Unit Test Results (build & test)

63 tests  ±0   63 :heavy_check_mark: ±0   3s :stopwatch: ±0s   1 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit d7666d0f. ± Comparison against base commit bb11384d.

:recycle: This comment has been updated with latest results.

TonyOuyangGit commented 9 months ago

I think this is probably due to the update for lint, without changing those source codes, the build is failing with the following files with lint errors, rerun the `./gradlew lintFix will solve the issue:

would reformat /home/runner/work/datahub-actions/datahub-actions/datahub-actions/src/datahub_actions/pipeline/pipeline_util.py
would reformat /home/runner/work/datahub-actions/datahub-actions/datahub-actions/src/datahub_actions/pipeline/pipeline.py
would reformat /home/runner/work/datahub-actions/datahub-actions/datahub-actions/src/datahub_actions/plugin/action/utils/term_resolver.py
would reformat /home/runner/work/datahub-actions/datahub-actions/datahub-actions/src/datahub_actions/utils/name_resolver.py