acryldata / datahub-actions

DataHub Actions is a framework for responding to changes to your DataHub Metadata Graph in real time.
42 stars 47 forks source link

`/start_datahub_actions.sh: datahub-actions: command not found` in `v0.0.18` #121

Open tom-webber opened 3 months ago

tom-webber commented 3 months ago

Deploying the v0.0.18 image on our platform causes a failure as so (we must run the container as non-root):

2024/07/23 16:18:45 Waiting for: http://datahub-datahub-gms:8080/health
2024/07/23 16:18:45 Received 200 from http://datahub-datahub-gms:8080/health
touch: cannot touch '/tmp/datahub/logs/actions/actions.out': Permission denied
No user action configurations found. Not starting user actions.
/start_datahub_actions.sh: line 68: datahub-actions: command not found
2024/07/23 16:18:45 Command exited with error: exit status 127
Stream closed EOF for data-platform-datahub-catalogue-dev/datahub-acryl-datahub-actions-78b977cb6b-fxsmn (acryl-datahub-actions)

The fatal issue appears to be reported by

/start_datahub_actions.sh: line 68: datahub-actions: command not found

which is this part of docker/datahub-actions/start.sh

else
    datahub-actions actions $config_files
fi

Which seems to suggest that datahub-actions is not installed, perhaps indicating that there's some issue with the pip cache. Speculation: perhaps related to the recent addition of USER root?

Side note: touch: cannot touch '/tmp/datahub/logs/actions/actions.out': Permission denied is not new. It is currently showing in the deployed v0.0.15 pod, so is not introduced in v0.0.18.

Version notes:

jjoyce0510 commented 3 months ago

Thanks for reporting this. Pretty uncertain why that root user change would have caused this. To confirm, 0.0.17 is the final working version?

tom-webber commented 3 months ago

I wasn't able to test versions v0.0.16 or v0.0.17 as the images were not available. Latest tested and working image is v0.0.15.

On Tue, 30 Jul 2024, 00:46 John Joyce, @.***> wrote:

Thanks for reporting this. Pretty uncertain why that root user change would have caused this. To confirm, 0.0.17 is the final working version?

— Reply to this email directly, view it on GitHub https://github.com/acryldata/datahub-actions/issues/121#issuecomment-2257202603, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATDGGFWOSMUFCSIHYPUQNDLZO3H6NAVCNFSM6AAAAABLMYQMOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJXGIYDENRQGM . You are receiving this because you authored the thread.Message ID: @.***>

github-actions[bot] commented 2 months ago

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

hsheth2 commented 1 month ago

I haven't really been able to repro this

For example, this works fine for me - even though it runs as non-root

docker run --rm -it --user datahub --entrypoint sh acryldata/datahub-actions:v0.0.18 -c 'datahub-actions actions --help'

Is your setup messing with the PATH env variable at all?

github-actions[bot] commented 3 weeks ago

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

ELCapitanLLNL commented 1 week ago

Hello, I am getting same issue with version: docker.io/acryldata/datahub-actions:v0.1.1

Log:

2024/11/05 20:17:55 Ready: http://datahub-datahub-gms:8080/health.
touch: cannot touch '/tmp/datahub/logs/actions/actions.out': Permission denied
ls: cannot access '/etc/datahub/actions/conf/': No such file or directory
No user action configurations found. Not starting user actions.
/start_datahub_actions.sh: line 68: datahub-actions: command not found
kevin-astrafy commented 6 days ago

I just upgraded to datahub 0.14.1 which also upgraded the datahub-action from 0.0.15 to 0.1.1 and i'm getting the same issue described above. I had to revert the datahub-action image to 0.0.15 to be able to deploy it via the helm chart