search

acryldata / datahub-actions

DataHub Actions is a framework for responding to changes to your DataHub Metadata Graph in real time.
42 stars 47 forks source link

fix(retries): move handle failure code outside of while loop #123

Closed nmbryant closed 1 month ago

nmbryant commented 2 months ago

The handle failure code is in the while loop, so after a single failure it will run the _handle_failure function. The retries will still happen if the failure_mode is set to CONTINUE, but if it's set to THROW it will throw an exception after the first failure. With these lines outside of the loop, it will still log when an attempt fails and then once all retries are exhausted it will print the actual failure message and throw and exception if set to THROW mode.

github-actions[bot] commented 1 month ago

Unit Test Results (build & test)

63 tests  ±0   63 :white_check_mark: ±0   4s :stopwatch: ±0s  1 suites ±0    0 :zzz: ±0   1 files   ±0    0 :x: ±0 

Results for commit 0904d324. ± Comparison against base commit 36aa93e8.

:recycle: This comment has been updated with latest results.