acryldata / datahub-helm

Repository of helm charts for deploying DataHub on a Kubernetes cluster
Apache License 2.0
160 stars 239 forks source link

fix: fix custom command & args behavior #422

Closed travis-cook-sfdc closed 9 months ago

travis-cook-sfdc commented 9 months ago

Fix two issues with the custom command & args behavior added in #408:

  1. Change custom command & args to use toRawJson instead of toJson. Previously, this resulted in special character would be escaped.

For example, this value:

args: [ "source setup.sh && /datahub/datahub-gms/scripts/start.sh" ]

Would get rendered as:

args: [ "source setup.sh \u0026\u0026 /datahub/datahub-gms/scripts/start.sh" ]

Use toRawJson to force special values to not be escaped

  1. Add custom command & args to all other containers that do not support it:
    • Datahub cleanup job
    • Datahub Nocode Migration Job
    • Datahub Restore Indices Job
    • Datahub System Update Job
    • Datahub Actions
    • Elastic Search Setup
    • Kafka Setup
    • Mysql Setup
    • Postgres setup

Checklist