acryldata / datahub-helm

Repository of helm charts for deploying DataHub on a Kubernetes cluster
Apache License 2.0
160 stars 238 forks source link

HelmChart release cycle vs Datahub updates #486

Closed kzgrzendek closed 1 month ago

kzgrzendek commented 1 month ago

Hello,

First of all, I'd like to thank you for the quality of your product - it's awesome!

I have a question regarding the versioning of the Helmchart and its release cycle :

Datahub v0.13.3 released in May, yet if I look at the appVersion tag of the latest HelmChart (0.4.19, released 3 weeks ago), I still see 0.13.2.

Is it just a bug, and that chart is in fact packaging the 0.13.3 Datahub version? More generally, are you guys updating the chart and its components at every Datahub release, or do expect the users to manually update the versions of the chart's dependencies to keep it updated?

Thanks! :)

Philipp-Hillen-SG commented 1 month ago

Was there any reaction through some other channel on this?

pedro93 commented 1 month ago

Hello,

DataHub releases usually include both the application code + helm chart releases.

When we don't do helm chart releases it is usually because just bumping the version of DataHub to match the application release version is sufficient.

kzgrzendek commented 1 month ago

@pedro93 thanks for your reply :)

That's a shame because it prevents an easy management of the application's life cycle in production (since it forces users to pull the helm chart and manually bump the dependencies' versions instead of just fetching the latest chart version from the repository and update it with dedicated tools like argocd/updatecli/etc).

It's also quite error-prone imo given the number of dependencies to update.

Is there any plans for a github action or something else that would auto publish the latest chart's version?

Thanks!

pedro93 commented 1 month ago

Not to my knowledge maybe @david-leifker is able to answer

darnaut commented 1 month ago

@kzgrzendek just to make sure we are on the same page here, are you aware that all it takes is to bump the .datahub.version option? e.g. via your Helm values file or simply as a Helm option https://github.com/acryldata/datahub-helm/blob/c8d01c4336c3f80f67e3af8a214bb7006a2dae7a/charts/datahub/values.yaml#L676

because otherwise I'm frankly quite surprised that this is error-prone.

We update the default version in the Helm chart when we want to widely rollout a DataHub release by default, not whenever a release is made. It's just a default, it's up to Chart users to select a version if they want something other than the default.

kzgrzendek commented 1 month ago

Hey @darnaut, thanks for your feedback!

I haven't dig enough to find that parameter, that should indeed answer my question. Just to check, is it documented somewhere besides the values.yaml definition? I think that solves a critical concern, and as the update mechanism differs a bit from the conventional helm chart version update, it would be great to have a little update section somewhere in the docs imo.

I'm gonna close that question, thank you