acrylian / zp_picturefill

A Zenphoto plugin for responsive images
GNU General Public License v3.0
0 stars 1 forks source link

Typo #4

Closed Bruno21 closed 10 years ago

Bruno21 commented 10 years ago

1_ There is a < /picture > tag which is not open:

Line 111

$html = '<!--[if IE 9]><video style="display: none;"><![endif]-->';

should be

$html .= '<!--[if IE 9]><video style="display: none;"><![endif]-->';

2_ There is 2x $alt variable in printHDImageThumb function:

Line 456

function printHDImageThumb($alt, $hd = false, $alt = NULL, $class = NULL, $id = NULL, $imgobj = null) {

should be

function printHDImageThumb($hd = false, $alt = NULL, $class = NULL, $id = NULL, $imgobj = null) {

3_ Variable $option in function getOptionsSupported() is not defined Line 456

    array(gettext('HD thumb quality') => array('key' => 'zp_picturefill_thumbquality', 'type' => OPTION_TYPE_TEXTBOX,```
should be
$option = array(gettext('HD thumb quality') => array('key' => 'zp_picturefill_thumbquality', 'type' => OPTION_TYPE_TEXTBOX,```
acrylian commented 10 years ago

You can stare on things for hours and still miss them… Indeed thanks very much.