search

acsestech / virtualassociate

0 stars 0 forks source link

Approve Profile feature #84

Closed bhargavibindhu closed 7 years ago

bhargavibindhu commented 8 years ago

Approve profile feature lists out all the records that are pending for approval.

  1. Issue 1: There is only "Approve Changes" option in this page. If the admin has to reject the change, how is this addressed?
  2. Issue 2: The Admin approves profile changes and it is saved. But if the admin logins again, even the Approved user profiles are also listed in the pending approvals. Please fix this.

It is very difficult to identify and keep track of the changes made the user and the admin approvals. I prefer this page can be done like any other pages eg: vendor listing, client listing, consultant listing page etc.

bhargavibindhu commented 8 years ago

There are multiple issues in this functionality.

  1. I do not have reject option if I have to reject a profile change.
  2. The approval entries are getting duplicated here.
  3. I do not have any idea on how many records i have to approve. ( no count or no listing).
  4. This approval entries has to be listed one by one as seen in other pages.
NaziniSK commented 8 years ago

this is considering as enhancement , will do this later

bhargavibindhu commented 7 years ago

The current functionality is not baselined. Let us first fix it and then plan for enhancement. Points listed in https://github.com/acsestech/virtualassociate/issues/84#issuecomment-260577550 covers only the basic expected behaviour of the Approve user profile module. Request you to do the needful.

bhargavibindhu commented 7 years ago

Approve user profile is not working and triggers error. This is the known bug as per Sandips email. Please fix it ASAP.

image

NaziniSK commented 7 years ago

image

if current data is last one and you are clicking next ">" or if current data is first you are clicking previous "< ", then only this message is showing,otherwise it will show the records.

bhargavibindhu commented 7 years ago

if it is first or last record, disable the navigation. Try for some solution such that this error is happening.

NaziniSK commented 7 years ago

image showing like this if no previous or next records found

NaziniSK commented 7 years ago

when you click on cancel it will take you to next record, and when you click on refresh it will show first or default record.

bhargavibindhu commented 7 years ago

Rename "Cancel" as "Next". Rename "Refresh" as "Go to First". Place the buttons in the below order. "Go to First", "Approve Changes", "Next"

NaziniSK commented 7 years ago

image done