search

acsiomatic / device-detector-bundle

Symfony Bundle for https://github.com/matomo-org/device-detector
https://packagist.org/packages/acsiomatic/device-detector-bundle
MIT License
10 stars 1 forks source link

PHP 8.1 support #17

Closed renanbr closed 2 years ago

renanbr commented 2 years ago

closes #16

renanbr commented 2 years ago

According to the CI, this library is compatible with PHP 8.1.

The pending issue is we can't test against PHP 8.1 locally because jakzal/phpqa doesn't yet release it. Actually, this image relies on the official image, so it's unlikely that it will be available before the official release. That's why I think we can merge it and solve the local test through this image once the mentioned image is available.

We could also be explicit in terms of PHP requirement constraints in the composer.json file. I start thinking putting >=7.0 isn't a good idea, because we can't guarantee the library is compatible with all future PHP major versions. I'm proposing also changing it to something more explicit. A better constraint could be ^7.2 || ^8.0. I'm also not sure if we should handle it in this PR.

I'm moving then this PR to ready to review.