search

acsone / bobtemplates.odoo

A set of mr.bob templates to use when developing Odoo addons.
GNU Lesser General Public License v3.0
48 stars 47 forks source link

[RFC] Change templates to take into account black formatting #30

Closed rousseldenis closed 5 years ago

sbidoul commented 5 years ago

Why not. Not sure it's worth the effort though, because your editor or pre-commit hook will do it anyway for you.

rousseldenis commented 5 years ago

Yes, I had that in mind writing this. But, that can decrease changes in pre-commits.

ThomasBinsfeld commented 5 years ago

I don't think bobtemplates should be Black-compliant. Plus, Black formatting depends on a project-level config. And i like simple quotes by default in manifests.

sbidoul commented 5 years ago

Yes as long as OCA is not black compliant, it's better to stay as close as possible to the OCA template. For projects that are black compliant, it's easy enough to blacken the code after template generation.