search

acsone / setuptools-odoo

A library to help packaging Odoo addons with setuptools. It mainly populates the usual setup.py keywords from the Odoo manifest files.
GNU Lesser General Public License v3.0
41 stars 46 forks source link

Use setuptools_scm as git file finder #29

Closed sbidoul closed 6 years ago

sbidoul commented 6 years ago

Remove dependency on unmaintained setuptools-git.

Closes #23

coveralls commented 6 years ago

Coverage Status

Coverage increased (+1.0%) to 84.192% when pulling 399cdcfc231502bf975f79c2da90bdba35f151c1 on git_file_finder-sbi into f1dc4710e9930deb56b28f02c1edd85de7d31878 on master.

sbidoul commented 6 years ago

@lmignon thanks for testing! I fixed a corner case in 5f97ff4.

Could you test again? Make sure you don't have setuptools-git nor setuptools-scm installed in the test environnement, since the file finders they provide could kick in in addition to this one.

lmignon commented 6 years ago

@sbidoul Ok pipeline relaunched. In my requirements.txt file setuptools-git has been removed and I reference your branch of setuptools-odoo. But indeed, if one of these 2 packages is installed into server's python lib, my test is not significant.

sbidoul commented 6 years ago

Waiting for setuptools_scm 2.1 to be released.

sbidoul commented 6 years ago

Done manually at a36bbf21491af68b563c87d40cd3404af93caca9