fix: test if variable is a list

acsone / setuptools-odoo

A library to help packaging Odoo addons with setuptools. It mainly populates the usual setup.py keywords from the Odoo manifest files.

GNU Lesser General Public License v3.0

41 stars 46 forks source link

fix: test if variable is a list #88

Closed vrenaville closed 2 years ago

vrenaville commented 2 years ago

Purpose On some enterprise module (we want to make pip install of enterprise module), some of them have author as a list.

sbidoul commented 2 years ago

Hm I'm not sure we want to encourage that.

Actually setuptools-odoo knowns all the official CE+EE addons and will never generate a dependency on them. You are supposed to deploy them separately, either by merging them into your main Odoo deployment, or by creating a multi-addons package for OE, with a setup.py (there is an example in the README).

vrenaville commented 2 years ago

@sbidoul

Thanks for your quick review, and explanation, I understand your concern and I will go in the multi-addons packages direction.

So I close this issue.

Vincent

sbidoul commented 2 years ago

@vrenaville to package odoo/enterprise, you can now simply drop a pyproject.toml in its root directory, using hatch-odoo.

rachmataditiya commented 1 year ago

@vrenaville to package odoo/enterprise, you can now simply drop a pyproject.toml in its root directory, using hatch-odoo.

can we include external odoo addons repository? for example we have separate repository for dependencies