search

acsresearch / interlab

MIT License
17 stars 2 forks source link

improve car_negotiation notebook by installing modules first #62

Open Huge opened 11 months ago

Huge commented 11 months ago

I would have a look to integrate https://docs.python.org/3/library/getpass.html instead of( or parallel to) dotenv for accessing the LLM API here, that should be easier to get started fast.

spirali commented 11 months ago

Hi, thank you for your PR.

I think that it is generally good idea; however I am afraid of the situation that someone is running a development version (installed through poetry as we recommend it) and then open this notebook in the git repository and rewrites its own environment by the stable version from pip.

I have to think a little bit how to solve this situation.

For the getpass, I am totally ok with it is it is used when dotenv fails to load

Huge commented 11 months ago

Yeah, that is a valid concern. After a few tries I have found !python -c "import dotenv,langchain,interlab" || pip install python-dotenv langchain interlab would work-around quite well, although it is not very elegant/legible and on a second look would better be one such line for each module. I can update the PR code with this and getpass as fallback, just not sure if today.-)

Colab link in meanwhile.