act-now-coalition / can-scrapers

MIT License
9 stars 13 forks source link

Revert autodag scraper filtering #405

Closed smcclure17 closed 2 years ago

smcclure17 commented 2 years ago

My change in #401 to filter out scrapers with autodag set to false caused issues.

Setting autodag = False for TableauDashboard also set it to false for all of its subclasses, meaning none of them (about 12 in total, including the North Carolina scraper) were being included in the MainFlows 😬.

I'm sorry about this, I'm not sure how I didn't realize this at the time, but I'll do more testing before making similar changes in the future. Fortunately, this didn't affect any scrapers that we are currently using, but it does mean that we lost ~10 days of history for the scrapers that were filtered out. This reverts the filtering to the old method (explicitly removing the scrapers during the collection).