search

act-now-coalition / covid-data-model

Data backend providing computed data for the graphs displayed at https://covidactnow.org
https://covidactnow.org/
MIT License
149 stars 57 forks source link

combine by distribution #1117

Closed TomGoBravo closed 3 years ago

TomGoBravo commented 3 years ago

This PR addresses https://trello.com/c/F76nvt6x/1375-combine-data-sources-per-distribution-instead-of-per-field

This depends on https://github.com/covid-projections/covid-data-public/pull/222

Tested

./run.py data update then git difftool --no-prompt -t vimdiff main -- data/multiregion-wide-dates.csv shows many new timeseries.

Counties in many states (AL, CT, FL, GA, IA, ID, IL, IN, MD, MI, MN, MO, MS, MT, NC, ND, NJ, NM, NY, OR, VT, WA, WV, WY) add vaccinations_completed with buckets age:18_plus,age:65_plus.

In MA some counties add vaccinations_completed all from CDC and vaccinations_initiated all estimate_initiated_from_state_ratio. 3 counties add vaccinations_completed all blocked without a public note.

DC and WI state level add lots of new non-all distributions for cases, deaths, vaccinations.

NE state, TN state, PA state and one county (iso1:us#iso2:us-pa#fips:42101) add a bunch of non-all vaccine distributions.

TN counties add cases age distributions.

TomGoBravo commented 3 years ago

Combine data sources per distribution instead of per field

mikelehen commented 3 years ago

though they seem to be blocked further down the pipeline

Hrm... we should be blocking 3 MA counties, but not sure why others would be getting blocked!

Also, looks like there are some unit test failures FYI.

TomGoBravo commented 3 years ago

though they seem to be blocked further down the pipeline

Hrm... we should be blocking 3 MA counties, but not sure why others would be getting blocked!

Data was correct, description wrong. Updated it.

Also, looks like there are some unit test failures FYI.

Fixed now that PdFields is update.