act-now-coalition / covid-data-model

Data backend providing computed data for the graphs displayed at https://covidactnow.org
https://covidactnow.org/
MIT License
149 stars 57 forks source link

Allow region to be a comma-separated list in region-overrides.json. #1136

Closed mikelehen closed 3 years ago

mikelehen commented 3 years ago

Tested via ./run.py data update and verifying multiregion-wide-dates.csv and manual_filter_removed-wide-dates.csv did not change.

TomGoBravo commented 3 years ago

https://github.com/covid-projections/covid-data-model/blob/main/tests/libs/datasets/manual_filter_test.py#L235 is an example of making the KNOWN_ISSUE_NO_DATE tag in expected data when blocked is true. You could alternatively change blocked to false and add the tag like TimeseriesLiteral([6, 8], annotation=[tag]), which avoids the complication of adding a tag to a timeseries with no real values.

mikelehen commented 3 years ago

Metric blocking: Support single override targeting multiple FIPS.