act-now-coalition / covid-data-model

Data backend providing computed data for the graphs displayed at https://covidactnow.org
https://covidactnow.org/
MIT License
149 stars 57 forks source link

Add vaccine booster doses to API #1220

Closed smcclure17 closed 2 years ago

smcclure17 commented 2 years ago

https://data.covidactnow.org/snapshot/2807/v2/county/36019.timeseries.json snapshot was generated with this PR.

I mostly followed #1007 and #1171 in making these changes

smcclure17 commented 2 years ago

I think I addressed all the comments, thanks as always for the feedback! 🙏 🙏

Re:

If you want to merge this today, I can monitor and double-check it succeeds tonight.

I'd like to merge this either tonight or tomorrow, but am also fine with waiting. I'll kick off a snapshot with this now, and if it succeeds we can merge?

mikelehen commented 2 years ago

Sure, sounds good!

smcclure17 commented 2 years ago

Looks like it was successful, but I'm remembering now that we had tentative plans to do some comms/partnerships work before releasing this. Maybe we should wait until Tuesday to ship this so Tom has time to think that through?

mikelehen commented 2 years ago

I think it's probably okay to merge but maybe just don't publish the api docs until we're ready to officially announce it?

smcclure17 commented 2 years ago

Ah, yeah, that sounds good to me! I'll undo the data changes and merge 🙏