search

act-now-coalition / covid-data-model

Data backend providing computed data for the graphs displayed at https://covidactnow.org
https://covidactnow.org/
MIT License
149 stars 57 forks source link

Restore demographic vaccine data #1286

Closed smcclure17 closed 2 years ago

smcclure17 commented 2 years ago

Demographic data was getting clobbered/removed from the MultiregionDatasets due to my use of timeseries instead of timeseries_bucketed. This updates the code where necessary to restore demographic data

post-fix: https://gist.githubusercontent.com/smcclure17/a50c3c6395bb37552771104b11279c8f/raw/a1ad4a60a4fd6af40d1807f26b7ec0d2d23f3a12/ca-06037.json

pre-fix: https://gist.githubusercontent.com/smcclure17/2365b842dbbb510d620453298957ce52/raw/4edb7fe774f88e8f80bfd90a8ba9a9407efb9418/ca-06037.json

smcclure17 commented 2 years ago

Yeah, good idea. I think it might be best to make sure to test each new function/feature using a dataset with demographic data. I'm not sure there's an easy way to test the entire ./run.py data update task without having the expected output change with each added update. I'm not too great at thinking of/designing tests though, so definitely open to ideas.