act-now-coalition / covid-data-model

Data backend providing computed data for the graphs displayed at https://covidactnow.org
https://covidactnow.org/
MIT License
149 stars 57 forks source link

Bump Metric Lookback #1366

Closed BrettBoval closed 1 year ago

BrettBoval commented 1 year ago

The main change is to push back the metric lookback date to three weeks. This has only been an issue with DNC recently, and it's been causing locations to turn Unknown for one day before the DNC ffill override kicks in. So the observed behavior is "Green-Grey-Green". I'd rather just have it remain green, which screws with the email alerts less.

There's a secondary fix to the pre-commit hooks. The pre-commit black uses it's own internal environment which accidentally broke with a dependency upgrade (click) (see black issue). I tried to just upgrade the pre-commit black, but it has different suggestions than the pinned black+click, so the pre-commit and GH-CI tools got into a recursive fight over formatting. I could update the main environmental black, but we use click for our own cli, so this would be a pretty big package upgrade that I don't want to test right now.