search

act-rules / act-rules-web

Source for ACT Rules website
https://act-rules.github.io/
Other
3 stars 5 forks source link

Glossary recursion #23

Closed WilcoFiers closed 4 years ago

WilcoFiers commented 5 years ago

Definitions often include other definitions. Those recursively linked definitions need to be added to the rule. For example here: https://auto-wcag.github.io/auto-wcag/rules/SC2-5-3-label-content-name-mismatch.html#visible-on-the-page

jeeyyy commented 5 years ago

Fixed in - https://github.com/auto-wcag/auto-wcag/pull/437

Jym77 commented 5 years ago

This is currently not working.

For example, the rule ARIA state or property allowed refers to "semantic role", which is included on the page. But "semantic role" refers to "explicit semantic role" which is not included on the page.

Given the way the links to glossary are currently generated, this results in a broken link to https://act-rules.github.io/rules/5c01ea/#explicit-role being here.

jeeyyy commented 5 years ago

PR in place - https://github.com/act-rules/act-rules.github.io/pull/857

jeeyyy commented 5 years ago

See comment - https://github.com/act-rules/act-rules.github.io/pull/857#issuecomment-529893002

Jym77 commented 4 years ago

This is still not working and currently (rightfully) blocking TF adoption of rules. See Kathy's last comment in https://github.com/w3c/wcag-act/issues/467

jeeyyy commented 4 years ago

PR in place - https://github.com/act-rules/act-rules-web/pull/209. Please re-open issue if need be.