search

act-rules / act-rules-web

Source for ACT Rules website
https://act-rules.github.io/
Other
3 stars 5 forks source link

feat: add Acknowledgements component to render in Rule page #47

Closed offsetChris closed 5 years ago

offsetChris commented 5 years ago

Addresses Issue #35

Not completely sure if this is how you want to handle this issue. Was trying to come up with a non-breaking change that can accommodate what is out there currently and reuse the existing function. Open to suggestions. Also unsure about how to tell graphQL I added a new field to pass the build here.

If this works will need to add corresponding previous_authors to rules repo rule templates.

jeeyyy commented 5 years ago

@offsetChris, thanks for this. I have put together a PR in the rules repo for this change - https://github.com/act-rules/act-rules.github.io/pull/997.

jeeyyy commented 5 years ago

I am switching the branch to the fix above from ACT rules with the correct frontmatter & testing this code

image

jeeyyy commented 5 years ago

@offsetChris I updated the PR, extracted every logic needed for acknowledgements to a component.

jeeyyy commented 5 years ago

@offsetChris can you handle the above 2 change requests from @WilcoFiers?

jeeyyy commented 5 years ago

@offsetChris I got around to this. Ta.