Add example generic-title example to title-descriptive rule

act-rules / act-rules.github.io

Accessibility conformance testing rules for HTML

https://act-rules.github.io/

Other

137 stars 70 forks source link

Add example generic-title example to title-descriptive rule #1964

Closed WilcoFiers closed 1 year ago

WilcoFiers commented 2 years ago

As suggested by Detlev Fisher.

Need for Call for Review: 1 week

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

bruce-usab commented 2 years ago

Since this is a Markdown file, is it possible to get preview rendering within the GitHub UI? If so, please help me with that.

Jym77 commented 2 years ago

Since this is a Markdown file, is it possible to get preview rendering within the GitHub UI? If so, please help me with that.

@bruce-usab When in "File change" view, you can click on the meatballs meatball menu of each file (named "Show options") and chose the "View File" option.

Screenshot of Github "file changed" view, highlighting the open "Show options" menu and the "View File" option in it

(this shows the full file in its current state, post-changes; it may be harder to spot the changes while viewing it that way…)