In #1831 we accidentally remove a negation in the expectation and thus totally broke the rule 🙈
Fixing this here.
Plus copying the expectation for the "no exception" rule to align with the other one.
Closes issue(s):
N/A
Need for Call for Review:
This will require a 1 week Call for Review (fixing a broken expectation without changing the intend).
Pull Request Etiquette
When creating PR:
[X] Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
[X] Make sure you do not remove the "How to Review and Approve" section in your pull request description
After creating PR:
[X] Add yourself (and co-authors) as "Assignees" for PR.
[X] Add label to indicate if it's a Rule, Definition or Chore.
[X] Optionally request feedback from anyone in particular by assigning them as "Reviewers".
When merging a PR:
[ ] Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.
How to Review And Approve
Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.
In #1831 we accidentally remove a negation in the expectation and thus totally broke the rule 🙈 Fixing this here. Plus copying the expectation for the "no exception" rule to align with the other one.
Closes issue(s):
Need for Call for Review: This will require a 1 week Call for Review (fixing a broken expectation without changing the intend).
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve