"HTML page has lang attribute" (b5c3f8): Improve examples - Githubissues

act-rules / act-rules.github.io

Accessibility conformance testing rules for HTML

https://act-rules.github.io/

Other

137 stars 69 forks source link

"HTML page has lang attribute" (b5c3f8): Improve examples #2020

Closed Jym77 closed 1 year ago

Jym77 commented 1 year ago

Add actual text to all examples.
Add a lang attribute to Inapplicable examples, so they don't fail the SC.

Closes issue(s):

closes #1984

Need for Call for Review: This will require a 1 week Call for Review (updating examples)

Pull Request Etiquette

When creating PR:

[X] Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
[X] Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

[X] Add yourself (and co-authors) as "Assignees" for PR.
[X] Add label to indicate if it's a Rule, Definition or Chore.
[X] Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
[X] Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

[ ] Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Jym77 commented 1 year ago

Call for review ends on February 16th.

Jym77 commented 1 year ago

Call for review has ended. Merging.