act-rules / act-rules.github.io

Accessibility conformance testing rules for HTML
https://act-rules.github.io/
Other
136 stars 68 forks source link

Create focus-returns-trigger-9au0ou.md #2022

Open HelenBurge opened 1 year ago

HelenBurge commented 1 year ago

First draft of the 2.4.3 focus returns to trigger rule.

Adding a rule for testing the focus returning to the trigger tests.

Closes issue(s):

Need for Call for Review: This will require a 2 weeks Call for Review


Pull Request Etiquette

When creating PR:

After creating PR:

When merging a PR:

How to Review And Approve

dan-tripp-siteimprove commented 1 year ago

Okay, I pushed a "Passed Example 1". I'd like to know what you think of it, before I create other examples. The problem is that it will be hard for you to test it. You can't just copy and paste that HTML. I think that your options are:

  1. You can copy the multiple .css and .js files to your local machine and then edit some paths. (If you want to pursue this option, let me know.)
  2. Wait until it's built and released on the ACT rules site (i.e. https://www.w3.org/WAI/standards-guidelines/act/rules/) (this option seems like the worst one to me.)
  3. Discover some other method of viewing the built HTML before it gets published on the ACT rules site. (I don't know if this option exists. Maybe Jean-Yves or Wilco would.)
dan-tripp-siteimprove commented 1 year ago

I put "Passed Example 1" on a live test page. What do you think?

HelenBurge commented 1 year ago

Love it Dan! Thanks for all of your hard work :)

dan-tripp-siteimprove commented 1 year ago

I've been thinking about the examples that use a link (instead of a button) to open the modal. (i.e. passed examples 4, 5 and 6, and failed examples 3 and 4.) Is it best to include these? I gather that using a link in this way is a bad practice - discussed here, for example: https://stackoverflow.com/questions/38594369/is-it-more-accessible-to-use-a-button-or-a-to-open-close-a-modal . Even if people do it, we wouldn't want to encourage it, right?

dan-tripp-siteimprove commented 1 year ago

At any rate, I've updated and added some more examples: https://dan-tripp-siteimprove.github.io/act-cg-focus-returns-trigger-9au0ou-examples/passed-example-1.html https://dan-tripp-siteimprove.github.io/act-cg-focus-returns-trigger-9au0ou-examples/passed-example-2.html https://dan-tripp-siteimprove.github.io/act-cg-focus-returns-trigger-9au0ou-examples/passed-example-3.html https://dan-tripp-siteimprove.github.io/act-cg-focus-returns-trigger-9au0ou-examples/failed-example-1.html https://dan-tripp-siteimprove.github.io/act-cg-focus-returns-trigger-9au0ou-examples/failed-example-2.html

HelenBurge commented 1 year ago

I've been thinking about the examples that use a link (instead of a button) to open the modal. (i.e. passed examples 4, 5 and 6, and failed examples 3 and 4.) Is it best to include these? I gather that using a link in this way is a bad practice - discussed here, for example: https://stackoverflow.com/questions/38594369/is-it-more-accessible-to-use-a-button-or-a-to-open-close-a-modal . Even if people do it, we wouldn't want to encourage it, right?

I agree, but best to allow it as we do not say how to code, but how to test and it is possible to have links that activate modals :(

dan-tripp-siteimprove commented 1 year ago

I've been thinking about the examples that use a link (instead of a button) to open the modal. (i.e. passed examples 4, 5 and 6, and failed examples 3 and 4.) Is it best to include these? I gather that using a link in this way is a bad practice - discussed here, for example: https://stackoverflow.com/questions/38594369/is-it-more-accessible-to-use-a-button-or-a-to-open-close-a-modal . Even if people do it, we wouldn't want to encourage it, right?

I agree, but best to allow it as we do not say how to code, but how to test and it is possible to have links that activate modals :(

Fair. I'll try to do that later in May.