act-rules / act-rules.github.io

Accessibility conformance testing rules for HTML
https://act-rules.github.io/
Other
136 stars 68 forks source link

"Meta viewport allows for zoom" [b4f0c3] should have secondary requirement for 1.4.10 #2025

Closed Jym77 closed 1 year ago

Jym77 commented 1 year ago

Meta viewport allows for zoom has text in the background that sounds like it should have a secondary requirement to 1.4.10, but that secondary requirement is missing.

sboptum commented 1 year ago

@Jym77 Is the change needed here to simply add another expandable section under the heading?

Accessibility Requirements Mapping

Jym77 commented 1 year ago

@sboptum A bit more 😃 It needs to be listed as "secondary" in the frontmatter + adding a list to the SC in the Bibliography section. See, for example, how Meta refresh, no exception has secondary mapping to 2.2.1.

sboptum commented 1 year ago

@Jym77 Thank you. I'm unsure what this means "listed as "secondary" in the frontmatter". In this Meta refresh, no exception I don't see anything saying "secondary" nor "frontmatter". The only references to 2.2.1 appear in the Background, Bibliography, and Mapping sections.

Jym77 commented 1 year ago

@Jym77 Thank you. I'm unsure what this means "listed as "secondary" in the frontmatter". In this Meta refresh, no exception I don't see anything saying "secondary" nor "frontmatter". The only references to 2.2.1 appear in the Background, Bibliography, and Mapping sections.

Ah, sorry for the technicalities 😅 That's about the actual markdown files, not the resulting HTML (the markdown is automagically turned into HTML when building the website).

The "frontmatter" is the initial part of the file, between the first --- at the top of the file, and the next one, after authors and acknowledgement. IN the Meta refresh no delay file, it is this bit:

---
id: bisz58
name: Meta element has no refresh delay (no exception)
rule_type: atomic
description: |
  This rule checks that the `meta` element is not used for delayed redirecting or refreshing.
accessibility_requirements:
  wcag20:2.2.4: # Interruptions (AAA)
    forConformance: true
    failed: not satisfied
    passed: further testing needed
    inapplicable: further testing needed
  wcag20:3.2.5: # Change on Request (AAA)
    forConformance: true
    failed: not satisfied
    passed: further testing needed
    inapplicable: further testing needed
  wcag-technique:G110: # Using an instant client-side redirect
    forConformance: false
    failed: not satisfied
    passed: further testing needed
    inapplicable: further testing needed
  wcag-technique:H76: # Using meta refresh to create an instant client-side redirect
    forConformance: false
    failed: not satisfied
    passed: further testing needed
    inapplicable: further testing needed
  wcag20:2.2.1: # Timing Adjustable (A)
    secondary: True
input_aspects:
  - DOM Tree
acknowledgments:
  authors:
    - Jean-Yves Moyen
  funding:
    - WAI-Tools
htmlHintIgnore:
  # https://www.npmjs.com/package/htmlhint
  # (used with `npm test` to ensure validity of code snippets)
  - 'title-require'
---

This contains all the meta-data related to the rule, including the mappings. As you can see in the bit above the mapping to 2.2.1 as a secondary: true listing. This is the bit that the website generation code uses to know it is a secondary requirement 🤓

sboptum commented 1 year ago

https://github.com/act-rules/act-rules.github.io/pull/2035/