[cae760] Frame has non-empty accessible name

tombrunet commented 1 year ago

Adjustments to the rule based on conversation of task force conversations (Feb 16, 2023).

Fixes #1367 Fixes #1170

Note regarding the two above issues. There is no perfect answer here since the browser behaviors are all different. However, the approach in this PR was to ignore cases where it's clear that the author attempts to remove the iframe from the sequential focus navigation.

Need for Call for Review: This will require a 2 weeks Call for Review << new rule, or substantial changes affecting a large number of test cases, if in doubt, use this. >>

Pull Request Etiquette

When creating PR:

[x] Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
[x] Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

[x] Add yourself (and co-authors) as "Assignees" for PR.
[x] Add label to indicate if it's a Rule, Definition or Chore.
[x] Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
[x] Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

[x] Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

tombrunet commented 1 year ago

@Jym77 https://github.com/act-rules/act-rules.github.io/pull/2048 for adding contributor

tombrunet commented 1 year ago

@Jym77 I think I have everything you suggested resolved, and I re-requested review, but it still shows a change requested, not sure why. Can you re-review? Thanks.

Jym77 commented 1 year ago

@Jym77 I think I have everything you suggested resolved, and I re-requested review, but it still shows a change requested, not sure why. Can you re-review? Thanks.

Yes, the review needs to be dimissed… (Bottom box, "change requested" dropdown, dots menu on the review to dismiss). I've done it. dismiss review

Jym77 commented 1 year ago

@tombrunet This looks like this is good to go in Call for Review 🎉 Do you want me to do it?

tombrunet commented 1 year ago

@Jym77 I was out on vacation, but it's sent now.

act-rules / act-rules.github.io