Closed tombrunet closed 1 year ago
@Jym77 https://github.com/act-rules/act-rules.github.io/pull/2048 for adding contributor
@Jym77 I think I have everything you suggested resolved, and I re-requested review, but it still shows a change requested, not sure why. Can you re-review? Thanks.
@Jym77 I think I have everything you suggested resolved, and I re-requested review, but it still shows a change requested, not sure why. Can you re-review? Thanks.
Yes, the review needs to be dimissed… (Bottom box, "change requested" dropdown, dots menu on the review to dismiss). I've done it.
@tombrunet This looks like this is good to go in Call for Review 🎉 Do you want me to do it?
@Jym77 I was out on vacation, but it's sent now.
Adjustments to the rule based on conversation of task force conversations (Feb 16, 2023).
Fixes #1367 Fixes #1170
Note regarding the two above issues. There is no perfect answer here since the browser behaviors are all different. However, the approach in this PR was to ignore cases where it's clear that the author attempts to remove the iframe from the sequential focus navigation.
Need for Call for Review: This will require a 2 weeks Call for Review << new rule, or substantial changes affecting a large number of test cases, if in doubt, use this. >>
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve