Closed giacomo-petri closed 11 months ago
Updates:
I've kept the inapplicable example n. 7 with the custom modal. Let me know if it's better to remove it completely.
The name of the referenced rule
Iframe with interactive elements is not excluded from tab-order
is fine -- as is the content of the rule.But the name of this PR seems to be a double negative? It is very confusing! And maybe it does not matter?
Please change the PR name. If it were just "update iframe not focusable" I would have twice about the rule!
Title edited. The initial intent was to provide information about the specific update, avoiding a generic label such as "Update iframe rule", which doesn't help in filtering PR. Please, let me know if the new title makes sense.
Title edited. The initial intent was to provide information about the specific update, avoiding a generic label such as "Update iframe rule", which doesn't help in filtering PR. Please, let me know if the new title makes sense.
As a rule of thumb, I feel it is good to include the full name of the updated rule in the PR title. Including the rule ID can also help tracking them across change of name (the id is the stable name). I usually like to frontload these, but we have no strict PR naming convention.
"rule name" [rule ID]: verb something something. e.g. "iframe with interactive elements is not excluded from tab-order" [akn7bn]: Manage inert iframe element
(I feel that "update rule" is a bit redundant in a PR title, since PR are mostly made to update rules) (the current title is fine, no need to change it again)
onload
instead of after user activation;Call for review ends June 21
I don't think my own knowledge is too below average, so I recommend adding links for background reading. Here are two I found useful:
@bruce-usab Since ACT rules are intended to be published as official W3C documentation, we tend to avoid direct links (or citation) of commercial third parties, especially when they are themselves major players (we do not want to look like we favour one above the others). As much as we can, we'd rather stick with W3C documentation (HTML living standard, …)
This PR is in call for review for 2 weeks. Review ends Sept 29th.
This pull request manages inert iframe elements in iframe with interactive elements is not excluded from tab-order rule, excluding them from the applicability of the rule.
Updates:
Closes issue(s): https://github.com/act-rules/act-rules.github.io/issues/1965
Need for Call for Review: This will require a 2 weeks Call for Review
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve