Closed daniel-montalvo closed 1 year ago
@daniel-montalvo I guess I'm just not sure what you're hoping to get from this. We don't write rules in issues. We use pull requests for that. Why would rule templates need to be available as templates for issues?
I thought rough concept draft rules were first put in issues and, if consensus exists that these should be worked on, they’d be move to a PR for further refinement.
Then this does not seem to make much sense.
Best.
Daniel Montalvo
Accessibility Harmonization and Training Specialist
W3C/WAI
From: Wilco Fiers @.> Sent: Thursday, June 15, 2023 2:34 PM To: act-rules/act-rules.github.io @.> Cc: Daniel Montalvo @.>; Mention @.> Subject: Re: [act-rules/act-rules.github.io] Rule-issue-templates (PR #2072)
@daniel-montalvo https://github.com/daniel-montalvo I guess I'm just not sure what you're hoping to get from this. We don't write rules in issues. We use pull requests for that. Why would rule templates need to be available as templates for issues?
— Reply to this email directly, view it on GitHub https://github.com/act-rules/act-rules.github.io/pull/2072#issuecomment-1592961080 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ALYFOWQU2IO5WH75WTF5N6TXLL6MZANCNFSM6AAAAAAY4U3TVU . You are receiving this because you were mentioned.Message ID: @.***>
I agree that issues are not a good place to discuss fully written rules (i.e. using the full template) because they don't make it possible to comment on specific bits as PR review do, and as we do on every single rule proposed.
Thus said:
Proposes to add issue templates for composite and atomic rules, and to change to new GH issue template config Closes issue(s):
Need for Call for Review: other: Issue templates This will require a 1 week Call for Review
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve