search

act-rules / act-rules.github.io

Accessibility conformance testing rules for HTML
https://act-rules.github.io/
Other
136 stars 67 forks source link

Update element-lang-valid-de46e4.md #2093

Closed kengdoj closed 1 year ago

kengdoj commented 1 year ago

Remove <html> and <body> tags from the displayed code examples to remove unintended failures.

Closes #2091, which was identified during the annual re-review of this rule.

<html> without a lang attribute would be a failure of an SC that this rule does not map to.

Call for review: 1 week

WilcoFiers commented 1 year ago

@Jym77 Thanks for sharing your thought. We talked about it in TF, and I ended up changing my mind on this and agreeing with you. We shouldn't rely on people knowing browser magic to understand the examples.

kengdoj commented 1 year ago

Thanks, all.

I'm going to close this PR and open a new one to make the updates as @Jym77 suggested.