"Element with lang attribute has valid language tag" [de46e4]: Updated Failed Examples 4 and 5 to reflect Applicability - Githubissues

act-rules / act-rules.github.io

Accessibility conformance testing rules for HTML

https://act-rules.github.io/

Other

136 stars 67 forks source link

"Element with lang attribute has valid language tag" [de46e4]: Updated Failed Examples 4 and 5 to reflect Applicability #2094

Closed giacomo-petri closed 10 months ago

giacomo-petri commented 1 year ago

I've updated:

Failed Example 4
Failed Example 5

to reflect the updated Applicability, including a reference to the [text inheriting its programmatic language][] definition in each failure.

Closes issue(s): #2063

Need for Call for Review: This will require a 1 week Call for Review

Pull Request Etiquette

When creating PR:

[ ] Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
[ ] Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

[ ] Add yourself (and co-authors) as "Assignees" for PR.
[ ] Add label to indicate if it's a Rule, Definition or Chore.
[ ] Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
[ ] Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

[ ] Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

giacomo-petri commented 11 months ago

This PR is in call for review for 1 week. Review ends Sept 22nd.

carlosapaduarte commented 10 months ago

Call for review ended: merging