"Headers attribute specified on a cell refers to cells in the same table element" [a25f45]: require headers to be `th` elements - Githubissues

act-rules / act-rules.github.io

Accessibility conformance testing rules for HTML

https://act-rules.github.io/

Other

131 stars 67 forks source link

"Headers attribute specified on a cell refers to cells in the same table element" [a25f45]: require headers to be `th` elements #2110

Open tombrunet opened 10 months ago

tombrunet commented 10 months ago

Updates based on #1910

Added to the expectation that the referenced element is expected to be a th
Updated Pass 3 and Fail 4.

Closes issue(s):

closes #1910

Need for Call for Review:

This will require a 2 weeks Call for Review

Pull Request Etiquette

When creating PR:

[x] Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
[x] Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

[x] Add yourself (and co-authors) as "Assignees" for PR.
[x] Add label to indicate if it's a Rule, Definition or Chore.
[x] Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
[x] Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

[x] Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

tombrunet commented 10 months ago

@WilcoFiers I put in a change to the expectation based on the issue description, but I'm a bit hesitant about that. I think ATs handle this regardless of whether or not it points to a td or a th. We certainly don't have any fail examples here to demonstrate that. I certainly agree that the examples should be in line with the spec. But, should we: 1) Keep this change to the expectation 2) Revert the expectation and add a failure case where a headers attribute points to a td element 3) Revert the change and do not add new test cases