change the id of the other two new rules without deleting the older version đ
This results in two rules having the same id, which totally messes up the toolchain downstream (and rightfully so). This PR fixes that by totally removing the old rules.
Closes issue(s):
N/A
Need for Call for Review:
This will not require a Call for Review (correcting a messed up problem)
Pull Request Etiquette
When creating PR:
[x] Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
[x] Make sure you do not remove the "How to Review and Approve" section in your pull request description
After creating PR:
[x] Add yourself (and co-authors) as "Assignees" for PR.
[x] Add label to indicate if it's a Rule, Definition or Chore.
[x] Optionally request feedback from anyone in particular by assigning them as "Reviewers".
When merging a PR:
[ ] Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.
How to Review And Approve
Go to the âFiles changedâ tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the âReview changesâ button in the top right, select âApproveâ (if you are really confident in the rule) or "Request changes" and click âSubmit reviewâ.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.
In #1923 I messed up by:
id
of the other two new rules without deleting the older version đThis results in two rules having the same
id
, which totally messes up the toolchain downstream (and rightfully so). This PR fixes that by totally removing the old rules.Closes issue(s):
Need for Call for Review: This will not require a Call for Review (correcting a messed up problem)
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve